Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Community prompt to sign in #974

Closed
nighca opened this issue Oct 10, 2024 · 0 comments · Fixed by #995
Closed

Community prompt to sign in #974

nighca opened this issue Oct 10, 2024 · 0 comments · Fixed by #995
Assignees
@aofei

Comments

@nighca
Copy link
Collaborator

nighca commented Oct 10, 2024 •
edited
Loading

Part of #806

Related actions

  • "New project" & "Open project" in navbar
  • "Follow / Unfollow" in user profile page
  • "Follow / Unfollow" in user list (/user/:name/following, /user/:name/followers)
  • "My following created" in explore page
  • "Like" in project profile page

When any action in the list triggered and the user has not signed in, use UIConfirmDialog to guide the user to sign in:

  • Dialog title: "Sign in to continue"
  • Dialog content: "[Do ...] by signing in."
  • Dialog footer: [Cancel] [Sign in]

And we need to restore the page after sign-in finished.

Image
@aofei aofei self-assigned this Oct 16, 2024
@aofei aofei mentioned this issue Oct 16, 2024
Closed
aofei added a commit to aofei/.goplus.builder that referenced this issue Oct 18, 2024
@aofei
feat(auth): introduce sign-in guard
be892e2 
- Add `withSignInGuard` HOF to prompt users to sign in before executing
  protected actions.
- Add similar protection for specific routes using navigation guards.

Fixes goplus#974

Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
@aofei aofei mentioned this issue Oct 18, 2024
Merged
aofei added a commit to aofei/.goplus.builder that referenced this issue Oct 18, 2024
@aofei
feat(auth): introduce sign-in guard
f18853b 
- Add `useEnsureSignedIn` to prompt users to sign in before executing
  protected actions.
- Add similar protection for specific routes using navigation guards.

Fixes goplus#974

Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
aofei added a commit to aofei/.goplus.builder that referenced this issue Oct 18, 2024
@aofei
feat(auth): introduce sign-in guard
5799801 
- Add `useEnsureSignedIn` to prompt users to sign in before executing
  protected actions.
- Add similar protection for specific routes using navigation guards.

Fixes goplus#974

Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
@aofei aofei closed this as completed in 805a472 Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aofei aofei

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(auth): introduce sign-in guard aofei/.goplus.builder
2 participants
@nighca @aofei