refactor(ProjectOpenModal): align with community design #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nighca
reviewed
Oct 22, 2024
| listProject({ | ||
| owner: userStore.userInfo()?.name, | ||
| pageIndex: page.value, | ||
| pageSize: pageSize |
There was a problem hiding this comment.
不指定 orderBy 的话我看接口实现默认是根据 createAt 倒序；之前 home 跟 my projects 页面实现都是默认根据 updatedAt 倒序，我觉得这俩顺序都有合理性，不过最好是先保持一致？
There was a problem hiding this comment.
Fixes goplus#972 Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
|
This PR has been deployed to the preview environment. You can explore it using the preview URL. Warning Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team. |
nighca
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #972