In-editor overlay optimization #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
nighca
force-pushed
the
issue-1167
branch
2 times, most recently
from
2377c22 to
b0b1696
Compare
There was a problem hiding this comment.
Copilot reviewed 6 out of 21 changed files in this pull request and generated 1 comment.
Files not reviewed (15)
- spx-gui/src/components/editor/code-editor/ui/resource-reference/selector/ResourceSelector.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/resource-reference/ResourceReferenceUI.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/context-menu/ContextMenuUI.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/completion/CompletionCard.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/completion/CompletionUI.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/CodeEditorCard.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/context-menu/ContextMenu.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/hover/HoverCard.vue: Evaluated as low risk
- spx-gui/src/components/ui/menu/UIMenuItem.vue: Evaluated as low risk
- spx-gui/src/components/ui/UIDropdown.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/context-menu/ContextMenuTrigger.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/hover/HoverUI.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/CodeEditorUI.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/context-menu/index.ts: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/completion/index.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)
spx-gui/src/components/editor/code-editor/ui/hover/index.ts:69
- The new behavior introduced in the
hideHoverWithDelayfunction is not covered by tests.
private hideHoverWithDelay() {
nighca
commented
Jan 3, 2025
There was a problem hiding this comment.
基本是原来的 UIDropdown.vue 的逻辑，除了这几个变更：
- 改为 render function 的写法，以便准确地控制传给
NPopover的 slots - Prop
pos支持指定 size（width&height），此时 dropdown 的定位会考虑 size（就像对待 trigger 节点那样） - 原本通过
<style>设置的样式现在通过指定NPopover的style实现
aofei
reviewed
Jan 3, 2025
|
This PR has been deployed to the preview environment. You can explore it using the preview URL. Warning Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team. |
aofei
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1167.
UIDropdownfor in-editor layers, except for ContextMenu trigger.