Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI details for code editor #1201

Merged
merged 1 commit into from
Jan 7, 2025
Merged

UI details for code editor #1201

merged 1 commit into from
Jan 7, 2025

Conversation

nighca
Copy link
Collaborator

@nighca nighca commented Jan 7, 2025

No description provided.

Copy link

qiniu-prow bot commented Jan 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@nighca nighca marked this pull request as ready for review January 7, 2025 01:45
@nighca nighca requested a review from Copilot January 7, 2025 01:46

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

spx-gui/src/components/editor/code-editor/ui/hover/index.ts:98

  • Removing the title 'Fix' might affect the usability or functionality of the command. Consider keeping the title if it's required for the command to function correctly.
title: 'Fix',
Copy link
Member

@aofei aofei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有 conflict 要解决下

@qiniu-ci
Copy link

qiniu-ci commented Jan 7, 2025

This PR has been deployed to the preview environment. You can explore it using the preview URL.

Warning

Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team.

@nighca nighca merged commit 72e6893 into goplus:dev Jan 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants