Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Run vite build only after type-check has passed #136

Merged
merged 1 commit into from
Mar 1, 2024
Merged

CI: Run vite build only after type-check has passed #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spx-gui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"type": "module",
"scripts": {
"dev": "vite",
"build": "vite build",
"build": "vue-tsc --build --force && vite build",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个做法（--build --force）应该并不是常规的做法？这里说明下需要这么做的原因？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是和type-check一样的命令，官方vue模板就是这么做类型检查的

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

官方vue模板

有链接吗？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://vuejs.org/guide/typescript/overview
https://github.com/vuejs/create-vue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/vuejs/create-vue/blob/main/template/config/typescript/package.json

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vuejs/create-vue#274 (comment)

看起来官方自己加得也有点糊涂，先链接在这吧

"preview": "vite preview",
"type-check": "vue-tsc --build --force",
"lint": "eslint . --ext .vue,.ts --ignore-path .gitignore"
Expand Down
Loading