chore: sync Vite Modes with NODE_ENV
#944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nighca
reviewed
Sep 25, 2024
- Updated the `build` script in `package.json` to set `--mode` in the `vite build` command to always match `NODE_ENV` (defaults to `production`). - Simplified `.env` to serve primarily as documentation and to provide essential default values. - Renamed `.env.dev` and `.env.prod` to `.env.development` and `.env.production` as Vite doesn't recognize the former. - Added `.env.staging` for easier deployment configuration. - Symlinked `.env.development` to `.env.staging` for quicker development environment setup. - Renamed `VERCEL_PROXIED_API_BASE_URL` to `VITE_VERCEL_PROXIED_API_BASE_URL` for consistency with other variables. - Added support for configuring `NODE_ENV` build argument in `Dockerfile`. - Renamed `.github/workflows/build.yml` to `.github/workflows/publish-docker-image.yml`, simplified the script, and set the Docker build argument `NODE_ENV=staging`. Fixes goplus#929 Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
|
The PR environment is ready, please check the PR environment [Attention]: This environment will be automatically cleaned up after a certain period of time., please make sure to test it in time. If you have any questions, please contact the builder team. |
nighca
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildscript inpackage.jsonto set--modein thevite buildcommand to always matchNODE_ENV(defaults toproduction)..envto serve primarily as documentation and to provide essential default values..env.devand.env.prodto.env.developmentand.env.productionas Vite doesn't recognize the former..env.stagingfor easier deployment configuration..env.developmentto.env.stagingfor quicker development environment setup.VERCEL_PROXIED_API_BASE_URLtoVITE_VERCEL_PROXIED_API_BASE_URLfor consistency with other variables.NODE_ENVbuild argument inDockerfile..github/workflows/build.ymlto.github/workflows/publish-docker-image.yml, simplified the script, and set the Docker build argumentNODE_ENV=staging.Fixes #929
In Go+ Builder, we currently use only three environments:
development: Used solely for local development. For convenience, we often configure it similarly to thestagingenvironment.staging: A unified environment for everything that isn'tdevelopmentorproduction, merging traditionaltesting,qa, andstaging.production: Reserved strictly for the live production system.