Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: pagination & button radio group #954

Merged
merged 7 commits into from
Oct 8, 2024
Merged

ui: pagination & button radio group #954

merged 7 commits into from
Oct 8, 2024

Conversation

ComfyFluffy
Copy link
Collaborator

@ComfyFluffy ComfyFluffy commented Sep 26, 2024 •
edited
Loading

image image

@ComfyFluffy ComfyFluffy linked an issue Sep 26, 2024 that may be closed by this pull request
Community Pagination #936
Closed
@ComfyFluffy ComfyFluffy changed the title ui: pagination ui: pagination & radio group Sep 26, 2024
@ComfyFluffy ComfyFluffy linked an issue Sep 26, 2024 that may be closed by this pull request
Community RadioGroup #938
Closed
@ComfyFluffy ComfyFluffy changed the title ui: pagination & radio group ui: pagination & button radio group Sep 26, 2024
nighca
nighca reviewed Sep 27, 2024
View reviewed changes
spx-gui/src/components/ui/UIPagination.vue Outdated Show resolved Hide resolved
spx-gui/src/components/ui/UIPagination.vue Outdated Show resolved Hide resolved
spx-gui/src/components/ui/UIButtonRadioGroup.vue Outdated Show resolved Hide resolved
spx-gui/src/components/ui/UIButtonRadioGroup.vue Outdated
.ui-radio-group-container {
display: flex;
gap: 12px;
button {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

等清清休完假再跟她确认下这里的样式细节吧，button 应该至少是有 hover 反馈的

@qiniu-x qiniu-x
Copy link

qiniu-x bot commented Oct 8, 2024

[Git-flow] Hi @ComfyFluffy, There are some suggestions for your information:

Rebase suggestions

  • Following commits seems generated via git merge

    Merge remote-tracking branch 'upstream/dev' into dev

Which seems insignificant, recommend to use git rebase command to reorganize your PR.

For other git-flow instructions, recommend refer to these examples.

If you have any questions about this comment, feel free to raise an issue here:

@qiniu-ci
Copy link

qiniu-ci commented Oct 8, 2024

This PR has been deployed to the preview environment. You can explore it using the preview URL.

Warning

Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team.

@nighca nighca merged commit ee67a3e into goplus:dev Oct 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nighca nighca nighca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Community RadioGroup Community Pagination
3 participants
@ComfyFluffy @qiniu-ci @nighca