feat(spx-backend): implement Community API #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nighca
reviewed
Sep 30, 2024
aofei
force-pushed
the
implement-community-api
branch
from
c9606dc
to
bd7eb32
Compare
nighca
approved these changes
Sep 30, 2024
aofei
force-pushed
the
implement-community-api
branch
from
bd7eb32
to
a08b3d4
Compare
aofei
commented
Oct 8, 2024
aofei
force-pushed
the
implement-community-api
branch
from
a08b3d4
to
df80efe
Compare
aofei
force-pushed
the
implement-community-api
branch
from
df80efe
to
7a503b2
Compare
aofei
force-pushed
the
implement-community-api
branch
from
7a503b2
to
0609f07
Compare
aofei
force-pushed
the
implement-community-api
branch
from
0609f07
to
5271c4e
Compare
aofei
force-pushed
the
implement-community-api
branch
from
5271c4e
to
03c6ea1
Compare
aofei
force-pushed
the
implement-community-api
branch
from
03c6ea1
to
fd28a30
Compare
aofei
force-pushed
the
implement-community-api
branch
from
fd28a30
to
819e924
Compare
aofei
commented
Oct 12, 2024
| @@ -394,7 +390,7 @@ paths: | |||
| "204": | |||
| description: Successfully deleted the project. | |||
|
|
|||
| /project/liking/{owner}/{name}: | |||
| /project/{owner}/{name}/liking: | |||
There was a problem hiding this comment.
这个改动是不得已的，因为 yap 认为 /project/liking/{owner}/{name} 跟 /project/:owner/:name 冲突（yap 没有细分静态路由和参数路由的优先级）
aofei
force-pushed
the
implement-community-api
branch
from
819e924
to
5bbff67
Compare
aofei
commented
Oct 12, 2024
| @@ -165,13 +165,13 @@ const { | |||
| const c = category.value.value | |||
| const cPersonal = categoryPersonal.value.value | |||
| return listAsset({ | |||
| pageSize: 500, // try to get all | |||
| pageSize: 100, // try to get all | |||
There was a problem hiding this comment.
后端限制了 pageSize 的值在区间 [1, 100]。考虑到预期是要做分页的，所以我先遵循 api spec 把这里给改小了。
aofei
force-pushed
the
implement-community-api
branch
from
5bbff67
to
15efafa
Compare
aofei
force-pushed
the
implement-community-api
branch
from
15efafa
to
03232af
Compare
nighca
reviewed
Oct 14, 2024
spx-backend/cmd/spx-backend/get_project_#owner_#name_liking.yap
Outdated
Show resolved
Hide resolved
aofei
force-pushed
the
implement-community-api
branch
from
03232af
to
4419a37
Compare
aofei
force-pushed
the
implement-community-api
branch
from
4419a37
to
862a87c
Compare
Fixes goplus#920 Fixes goplus#948 Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
aofei
force-pushed
the
implement-community-api
branch
from
862a87c
to
8d93319
Compare
|
This PR has been deployed to the preview environment. You can explore it using the preview URL. Warning Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team. |
补充了测试 & 同步改动了前端，我本地测试了没啥问题，看看还需不需要再 review 下 |
nighca
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #920
Fixes #948
Breaking changes to the API spec
Model.cTimetoModel.createdAt.Model.uTimetoModel.updatedAt.IsPublictoVisibility.Visibilityas a self-descriptive string enum instead of an integer enum.Asset.assetTypetoAsset.type.Asset.typeas a self-descriptive string enum instead of an integer enum./user/following/{username}to/user/{username}/following./project/liking/{owner}/{name}to/project/{owner}/{name}/liking.requestBody.nameparameter fromPUT /project/{owner}/{name}.previewandclickCountproperties fromAsset.