Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spx-gui): implement playlist icon trigger completion menu #959

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

molinla
Copy link
Contributor

@molinla molinla commented Sep 28, 2024

Overview

this pr is about following updates:

  • implement playlist icon trigger completion item, after trigger will auto select play param named mediaName
  • refactor completion-item-cache into completion-staging-item and related codes
  • remove inlay-hint unnecessary codes
  • abstract completionProvider into a single file
  • some small bugs fix and code styles refactor

Copy link

qiniu-x bot commented Sep 28, 2024

[Git-flow] Hi @molinla, There are some suggestions for your information:


Rebase suggestions

  • Following commits have duplicated messages

    refactor: rename completion-staging-item related methods and members name

    refactor: rename completion-staging-item related methods and members name

Which seems insignificant, recommend to use git rebase command to reorganize your PR.

For other git-flow instructions, recommend refer to these examples.

If you have any questions about this comment, feel free to raise an issue here:

Copy link

qiniu-prow bot commented Sep 28, 2024

Hi @molinla. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@molinla
Copy link
Contributor Author

molinla commented Sep 29, 2024

@nighca thanks to review

Copy link
Collaborator

@nighca nighca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for PR :) @molinla

@@ -123,8 +123,9 @@ export class Compiler extends Disposable {

private reloadIframe() {
// each load will emit 'load' event, after 'load', will trigger `initIframe` function
this.containerElement?.contentWindow?.location.reload()
// fixme: fix when wasm crashed and reload not working
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有这种情况..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是在频繁修改代码的时候,同时这个代码会直接导致代码解析崩溃情况下,reload 后 windows 就不会挂载这些函数,我还需要再详细定位问题测试一下,我计划在 dignostic 遇到问题的时候就组织其它函数调用

@nighca nighca merged commit 1777573 into goplus:trailhead_code Sep 30, 2024
3 checks passed
@molinla molinla deleted the playlist_completion branch September 30, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants