Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge UIButtonRadio with UITag #968

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Merge UIButtonRadio with UITag #968

merged 2 commits into from
Oct 9, 2024

Conversation

nighca
Copy link
Collaborator

@nighca nighca commented Oct 8, 2024

close #967

  • Rename UIButtonRadio to UITagRadio
  • Use UITag to implement UITagRadio
  • Update style of UITag

Copy link

qiniu-prow bot commented Oct 8, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@@ -255,7 +255,7 @@ async function handleAssetClick(asset: AssetData) {
padding: var(--ui-gap-middle);
gap: 12px;

background: var(--ui-color-grey-200);
border-right: 1px solid var(--ui-color-grey-400);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UITag 的改动影响到 AssetLibraryModal 的样式,这里本来是背景色区分,调整为分隔线

@qiniu-ci
Copy link

qiniu-ci commented Oct 9, 2024

This PR has been deployed to the preview environment. You can explore it using the preview URL.

Warning

Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team.

@aofei aofei merged commit 68f71f8 into goplus:dev Oct 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge UIButtonRadio with UITag
3 participants