Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project publish #988

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Project publish #988

merged 2 commits into from
Oct 16, 2024

Conversation

nighca
Copy link
Collaborator

@nighca nighca commented Oct 16, 2024 •
edited
Loading

  • Project publish in editor, close Community Publish Project #977
  • Generate project thumbnail when saving to cloud
  • Update Navbar details
  • Simplify behavior of RunnerContainer

@qiniu-prow qiniu-prow
Copy link

qiniu-prow bot commented Oct 16, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@nighca nighca force-pushed the issue-977 branch 2 times, most recently from 510d812 to 69b4f60 Compare October 16, 2024 07:41
nighca
nighca commented Oct 16, 2024
View reviewed changes
spx-gui/src/models/project/index.ts Outdated
@@ -522,6 +551,9 @@ export class Project extends Disposable {
{ immediate: true }
)
)

// new created project has no thumbnail, do save to cloud to generate thumbnail
if (this.thumbnail === '') this.saveToCloud()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是合适的加这个逻辑的地方吗？

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉加在这里不太合适，相比之下放到 startEditing 里可能更合适些

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK，我来挪一下

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done b0f792d

@nighca nighca marked this pull request as ready for review October 16, 2024 07:50
@qiniu-ci
Copy link

This PR has been deployed to the preview environment. You can explore it using the preview URL.

Warning

Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team.

@nighca nighca merged commit 52fa2d2 into goplus:dev Oct 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aofei aofei aofei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Community Publish Project
3 participants
@nighca @qiniu-ci @aofei