refactor(sign-in): redirect to intended page after signing in #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nighca
reviewed
Oct 16, 2024
nighca
approved these changes
Oct 16, 2024
nighca
reviewed
Oct 17, 2024
| await userStore.completeSignIn() | ||
|
|
||
| const returnTo = params.get('returnTo') | ||
| window.location.replace(returnTo != null ? decodeURIComponent(returnTo) : '/') |
There was a problem hiding this comment.
params.get 应该已经做过一次 decodeURIComponent 了
There was a problem hiding this comment.
Fixes goplus#985 Fixes goplus#986 Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
|
This PR has been deployed to the preview environment. You can explore it using the preview URL. Warning Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team. |
nighca
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #985
Fixes #986