Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: article view and page view #202

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

xhyqaq
Copy link
Contributor

@xhyqaq xhyqaq commented Feb 27, 2024

No description provided.

@IRONICBo
Copy link
Collaborator

@xhyqaq Hi, please clear up your commits.

@xhyqaq xhyqaq force-pushed the feat/article-view branch 5 times, most recently from 02e9054 to 582a535 Compare February 28, 2024 08:06
@@ -124,15 +124,11 @@ get "/article/:id", ctx => {
}
}
id := ctx.param("id")
article, err := community.Article(todo, id)
article, _ := community.Article(todo, id)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do no shadow errors.

@@ -124,15 +124,11 @@ get "/article/:id", ctx => {
}
}
id := ctx.param("id")
article, err := community.Article(todo, id)
article, _ := community.Article(todo, id)
likeState,_:= community.ArticleLikeState(todo,userId,id)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

}
ip := community.GetClientIP(ctx.Request)
community.ArticleLView(todo,id,ip,userId)
articleJson, _ := json.Marshal(&article)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

Copy link
Collaborator

@IRONICBo IRONICBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IRONICBo IRONICBo merged commit dd426f1 into goplus:dev Feb 28, 2024
1 check passed
IRONICBo added a commit to IRONICBo/community that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants