feat: go list all pkgs and cache them to improve build speed #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #397 +/- ##
==========================================
- Coverage 96.16% 95.99% -0.18%
==========================================
Files 15 15
Lines 6076 6111 +35
==========================================
+ Hits 5843 5866 +23
- Misses 177 186 +9
- Partials 56 59 +3 ☔ View full report in Codecov by Sentry. |
LiusCraft
force-pushed
the
enhance/gop-issue-1710
branch
from
3137374
to
ea2344b
Compare
xushiwei
reviewed
Feb 25, 2024
packages/imp.go
Outdated
| @@ -40,6 +47,9 @@ func NewImporter(fset *token.FileSet, workDir ...string) *Importer { | |||
| if len(workDir) > 0 { | |||
| dir = workDir[0] | |||
| } | |||
| if len(packageCacheMap) == 0 { | |||
There was a problem hiding this comment.
can delay init at first time usage.
packages/imp.go
Outdated
| @@ -40,6 +47,9 @@ func NewImporter(fset *token.FileSet, workDir ...string) *Importer { | |||
| if len(workDir) > 0 { | |||
| dir = workDir[0] | |||
| } | |||
| if len(packageCacheMap) == 0 { | |||
| goListExportCache(".", "") | |||
packages/imp.go
Outdated
| // pkgPath Caches | ||
| var ( | ||
| packageCacheMap = map[string]string{} | ||
| mutex sync.Mutex |
There was a problem hiding this comment.
Don't need a mutex. use sync.Once.
packages/imp.go
Outdated
| "sync" | ||
|
|
||
| "golang.org/x/tools/go/gcexportdata" | ||
| ) | ||
|
|
||
| // pkgPath Caches | ||
| var ( | ||
| packageCacheMap = map[string]string{} |
There was a problem hiding this comment.
Dont use global variable. It can be a member of Importer
LiusCraft
force-pushed
the
enhance/gop-issue-1710
branch
4 times, most recently
from
d15e072
to
27b6a9f
Compare
LiusCraft
force-pushed
the
enhance/gop-issue-1710
branch
from
27b6a9f
to
3906ccb
Compare
LiusCraft
force-pushed
the
enhance/gop-issue-1710
branch
from
3906ccb
to
1ba3937
Compare
LiusCraft
force-pushed
the
enhance/gop-issue-1710
branch
from
1ba3937
to
aced8c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gop compiler is much slower than go
This PR optimization: reduce the number of times to execute the go list command to improve construction speed
Use this command to optimize the map cache:
exec Command ("go", "list", "- f", "{{. ImportPath}}", {{. Export}} "," - export "," all ")befor:
after:
