Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gopfmt: support classfile #1378

Merged
merged 3 commits into from
Jun 10, 2023
Merged

gopfmt: support classfile #1378

merged 3 commits into from
Jun 10, 2023

Conversation

visualfc
Copy link
Member

@visualfc visualfc commented Jun 4, 2023

gop fmt and gopfmt support lookup classfile

  • support load classfile from gopmod
  • support classfile embed type
  • add .gopx

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (247a4c9) 90.28% compared to head (50b0a01) 90.29%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1378   +/-   ##
=======================================
  Coverage   90.28%   90.29%           
=======================================
  Files          24       25    +1     
  Lines        9164     9166    +2     
=======================================
+ Hits         8274     8276    +2     
  Misses        724      724           
  Partials      166      166           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

cmd/internal/gopfmt/fmt.go Outdated Show resolved Hide resolved
load.go Outdated Show resolved Hide resolved
cmd/internal/gopfmt/fmt.go Outdated Show resolved Hide resolved
cmd/internal/gopfmt/fmt.go Outdated Show resolved Hide resolved
}
return
}
} else {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need use if..else

@xushiwei xushiwei merged commit 390a7ca into goplus:main Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants