-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): implement file synchronization methods and publish diagnostic notifications #47
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
+ Coverage 65.43% 66.55% +1.11%
==========================================
Files 38 39 +1
Lines 5772 6007 +235
==========================================
+ Hits 3777 3998 +221
- Misses 1755 1762 +7
- Partials 240 247 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… diagnostics handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements file synchronization methods on the server-side and publishes diagnostic notifications in response to LSP text document events. Key changes include:
- Addition of comprehensive tests for file modifications in gop/proj_test.go.
- Implementation of text document lifecycle handlers (didOpen, didChange, didSave, didClose) and asynchronous diagnostics in internal/server/text_syncronization.go.
- Introduction of the FileChange type and revised ModifyFiles logic in gop/proj.go, along with updating server notification handling in internal/server/server.go.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
gop/proj_test.go | Adds new tests covering file addition, update, and multiple file changes. |
internal/server/text_syncronization.go | Implements text synchronization and diagnostic publishing functionality. |
gop/proj.go | Introduces FileChange and updates ModifyFiles to use version-based updates. |
internal/server/server.go | Replaces placeholder TODOs with actual handler calls for notifications. |
Comments suppressed due to low confidence (1)
internal/server/text_syncronization.go:1
- [nitpick] The file name 'text_syncronization.go' appears to have a spelling mistake; consider renaming it to 'text_synchronization.go' for clarity and consistency.
package server
[Git-flow] Hi @go-wyvern, There are some suggestions for your information: Rebase suggestions
Which seems insignificant, recommend to use For other If you have any questions about this comment, feel free to raise an issue here: |
No description provided.