Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump github.com/goplus/gop from 1.3.5 to 1.3.6 #49

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

aofei
Copy link
Member

@aofei aofei commented Mar 17, 2025

This also reverts commit goplus/builder@60c8e97.

Fixes goplus/builder#1398
Updates goplus/builder#1378

@aofei aofei requested a review from Copilot March 17, 2025 01:46

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the github.com/goplus/gop dependency version and reverts a previous commit to address an issue in goplus/builder.

  • Reorders import statements in internal/pkgdata/gen/main.go to revert the changes introduced in commit goplus/builder@60c8e97.
  • Removes unused imports and helper functions (slices.DeleteFunc call and isNilNode) from internal/util/enclosing.go for cleanup.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

File Description
internal/pkgdata/gen/main.go Reordered imports to revert previous changes and align with dependency updates.
internal/util/enclosing.go Removed unused import dependencies and nil filtering logic.
Comments suppressed due to low confidence (2)

internal/pkgdata/gen/main.go:129

  • [nitpick] The reordering of import statements has been modified; please ensure that the new order conforms to the project's internal guidelines for grouping and ordering of imports.
"github.com/goplus/gop/builtin/ng",

internal/util/enclosing.go:469

  • The removal of the nil filtering for children in the childrenOf function may lead to unexpected nil nodes being processed; please verify that nil nodes are handled appropriately elsewhere.
children = slices.DeleteFunc(children, isNilNode)
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.43%. Comparing base (f946793) to head (d32fa0e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   65.45%   65.43%   -0.03%     
==========================================
  Files          38       38              
  Lines        5786     5771      -15     
==========================================
- Hits         3787     3776      -11     
+ Misses       1758     1755       -3     
+ Partials      241      240       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This also reverts commit goplus/builder@60c8e97.

Fixes goplus/builder#1398
Updates goplus/builder#1378

Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
@aofei aofei merged commit b7fefde into goplus:main Mar 17, 2025
4 of 5 checks passed
@aofei aofei deleted the gop branch March 17, 2025 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language server panic
2 participants