feat: Implement offline SPX project compilation and web-based execution #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visualfc
reviewed
Jan 15, 2024
offlineSpx/main.wasm
Outdated
visualfc
reviewed
Jan 15, 2024
offlineSpx/ifs/IndexdbDBWithJS.go
Outdated
There was a problem hiding this comment.
file name always lowercase, can be used _ separate.
visualfc
reviewed
Jan 15, 2024
| // IndexedDBFileSystem is the implementation of a fsx.FileSystem | ||
| type IndexedDBFileSystem struct{} | ||
|
|
||
| func NewIndexedDBFileSystem() IndexedDBFileSystem { |
There was a problem hiding this comment.
NewFunc returns no pointer type.
|
refactor: Reconstruction code to solve the problems mentioned in previous PR #6 |
visualfc
reviewed
Jan 15, 2024
.gitignore
Outdated
|
|
||
| .vscode/ | ||
| .idea/ | ||
| main.wasm |
visualfc
reviewed
Jan 15, 2024
offline_spx/ifs/indexdbDB_with_js.go
Outdated
There was a problem hiding this comment.
_js 本身就代表了明确的在 GOOS=js 上工作，所以这里不需要 with.
如果 ifs 本身不需要其他的 filesytem 实现，那么文件名可以简单的命名为 ifs_js.go, 不建议使用 indexdbDB 这种大小写的文件名用法。
|
refactor: Reconstruction code to solve the problems mentioned in previous PR #6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.