Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llgo/c/lua:link style #507

Merged
merged 1 commit into from
Jul 13, 2024
Merged

llgo/c/lua:link style #507

merged 1 commit into from
Jul 13, 2024

Conversation

luoliwoshang
Copy link
Contributor

@luoliwoshang luoliwoshang commented Jul 13, 2024

For macros, they are also considered to be generated by automated tools, and the naming convention is consistent with that of general functions.

#define lua_tonumber(L,i)	lua_tonumberx(L,(i),NULL)
#define lua_tointeger(L,i)	lua_tointegerx(L,(i),NULL)
#define lua_pop(L,n)		lua_settop(L, -(n)-1)

@luoliwoshang
Copy link
Contributor Author

luoliwoshang commented Jul 13, 2024

Do automated tools expect to process macros into corresponding Go functions, or is it expected that the tool only handles Link?

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.71%. Comparing base (9edeee4) to head (de4b5b7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #507   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files          19       19           
  Lines        4511     4511           
=======================================
  Hits         4408     4408           
  Misses         87       87           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiwei
Copy link
Member

Do automated tools expect to process macros into corresponding Go functions, or is it expected that the tool only handles Link?

Only handle abi (binary) by default. But macro will support some special cases (eg. enum).

@xushiwei xushiwei merged commit ef8be6c into goplus:main Jul 13, 2024
6 checks passed
@luoliwoshang luoliwoshang deleted the c/lua branch July 13, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants