ssa: add support for min and max built-in functions
#614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #614 +/- ##
==========================================
- Coverage 97.69% 97.57% -0.13%
==========================================
Files 19 19
Lines 4556 4569 +13
==========================================
+ Hits 4451 4458 +7
- Misses 88 94 +6
Partials 17 17 ☔ View full report in Codecov by Sentry. |
xushiwei
reviewed
Jul 30, 2024
| @@ -521,3 +521,34 @@ func TestBasicType(t *testing.T) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| func TestCompareSelect(t *testing.T) { | |||
There was a problem hiding this comment.
已经很少这样写测试案例了。推荐在 _testdata 目录里面加测试例子
There was a problem hiding this comment.
这个其实是因为不能在 _testdata 里面加所以才写成这样的，clear、min、max 都需要 go.mod 里的 go version 至少是 1.21
There was a problem hiding this comment.
另外加的话是不是也应该是加在 cl/_testrt/builtin 里才对？看目录结构感觉是的
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.