Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollback golang.org/x/tools v0.22.0 => v0.19.0 #686

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

xushiwei
Copy link
Member

@xushiwei xushiwei commented Aug 8, 2024

No description provided.

@xushiwei xushiwei merged commit c91dba5 into goplus:main Aug 8, 2024
2 checks passed
@aisk
Copy link
Contributor

aisk commented Sep 11, 2024

Hi @xushiwei, what's the reason why this mod was downgraded to v0.19.0? I tried to build the fmt package or os package, and got this error message:

panic: Cannot range over: func(yield func(E) bool)

goroutine 1096 [running]:
golang.org/x/tools/go/ssa.(*builder).rangeStmt(0xc0076222d0, 0xc006bd2820, 0xc003dce360, 0x0)
	/home/xxxxx/.go/pkg/mod/golang.org/x/tools@v0.19.0/go/ssa/builder.go:2279 +0x805
golang.org/x/tools/go/ssa.(*builder).stmt(0xc0076222d0, 0xc006bd2820, {0x8c3990?, 0xc003dce360?})
	/home/xxxxx/.go/pkg/mod/golang.org/x/tools@v0.19.0/go/ssa/builder.go:2503 +0x205
golang.org/x/tools/go/ssa.(*builder).stmtList(...)
	/home/xxxxx/.go/pkg/mod/golang.org/x/tools@v0.19.0/go/ssa/builder.go:909
golang.org/x/tools/go/ssa.(*builder).stmt(0xc0076222d0, 0xc006bd2820, {0x8c3810?, 0xc003dff230?})
	/home/xxxxx/.go/pkg/mod/golang.org/x/tools@v0.19.0/go/ssa/builder.go:2465 +0xe47
golang.org/x/tools/go/ssa.(*builder).buildFromSyntax(0xc0076222d0, 0xc006bd2820)
	/home/xxxxx/.go/pkg/mod/golang.org/x/tools@v0.19.0/go/ssa/builder.go:2577 +0x245
golang.org/x/tools/go/ssa.(*builder).buildFunction(0x7ee680?, 0xc006bd2820)
	/home/xxxxx/.go/pkg/mod/golang.org/x/tools@v0.19.0/go/ssa/builder.go:2531 +0x17b
golang.org/x/tools/go/ssa.(*builder).iterate(0xc0076222d0)
	/home/xxxxx/.go/pkg/mod/golang.org/x/tools@v0.19.0/go/ssa/builder.go:2519 +0x25
golang.org/x/tools/go/ssa.(*Package).build(0xc002227b80)
	/home/xxxxx/.go/pkg/mod/golang.org/x/tools@v0.19.0/go/ssa/builder.go:2648 +0xa9
sync.(*Once).doSlow(0xc00325bc50?, 0xc0033f37a0?)
	/usr/lib/go/src/sync/once.go:76 +0xb4
sync.(*Once).Do(...)
	/usr/lib/go/src/sync/once.go:67
golang.org/x/tools/go/ssa.(*Package).Build(...)
	/home/xxxxx/.go/pkg/mod/golang.org/x/tools@v0.19.0/go/ssa/builder.go:2637
golang.org/x/tools/go/ssa.(*Program).Build.func1(0x0?)
	/home/xxxxx/.go/pkg/mod/golang.org/x/tools@v0.19.0/go/ssa/builder.go:2620 +0x45
created by golang.org/x/tools/go/ssa.(*Program).Build in goroutine 1
	/home/xxxxx/.go/pkg/mod/golang.org/x/tools@v0.19.0/go/ssa/builder.go:2619 +0x187

Upgrade x/tools to v0.22 can avoid this problem, although the fmt or os cannot be linked for other reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants