Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix link fail for cjsondemo #909

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Conversation

tsingbx
Copy link
Contributor

@tsingbx tsingbx commented Dec 6, 2024

No description provided.

@tsingbx tsingbx force-pushed the llgo/linkerror branch 2 times, most recently from 0d9f903 to 2f6b6e1 Compare December 6, 2024 03:39
@luoliwoshang
Copy link
Contributor

luoliwoshang commented Dec 6, 2024

刚刚在你的pr comment中 fix issue中提到的链接错误是llcppg工具在生成llgo binding时的类型名称和llgo:link中的类型名称生成不一致导致的。

这个对llgo本身编译过程的修改是为了修复何种具体链接问题需要明确。

@tsingbx
Copy link
Contributor Author

tsingbx commented Dec 6, 2024

在llgo/cjson/_demo/mkjson 中,运行示例代码是没问题的。

issue中提到的链接错误是llcppg工具在生成llgo binding时的类型名称和llgo:link中的类型名称生成不一致导致的,这个对llgo修改是为了修复何种具体链接问题需要明确一下。

cjson/_demo/mkjson on  c/FILE [$!?] via 🐹 v1.20.4 
❯ llgo run .
{"hello":"llgo","hello":"llcppg"}
企业微信截图_90e0cd65-bd02-4d93-a0f7-683a208deb28

如果不这样做就会出现链接不上错误

@tsingbx tsingbx closed this Dec 6, 2024
@tsingbx tsingbx reopened this Dec 6, 2024
@luoliwoshang
Copy link
Contributor

如会议对齐,当前PR为修复LLGO本身的链接命令解析错误导致的符号缺失问题

@tsingbx tsingbx closed this Dec 6, 2024
@tsingbx tsingbx reopened this Dec 6, 2024
@tsingbx tsingbx force-pushed the llgo/linkerror branch 4 times, most recently from c5e2731 to e463195 Compare December 6, 2024 17:23
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.64%. Comparing base (4bec9b0) to head (af2bcd3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #909   +/-   ##
=======================================
  Coverage   97.64%   97.64%           
=======================================
  Files          22       22           
  Lines        6279     6279           
=======================================
  Hits         6131     6131           
  Misses        128      128           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


require (
github.com/goplus/llgo v0.9.9-0.20241205041715-4bec9b038b9a
github.com/tsingbx/libcjson v1.0.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

llgo 增加外部库的引用会非常谨慎。这个 cjsondemo 最好迁移到 llcppg repo 中。

@xushiwei xushiwei merged commit 5936b57 into goplus:main Dec 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants