-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix link fail for cjsondemo #909
Conversation
0d9f903
to
2f6b6e1
Compare
刚刚在你的pr comment中 fix issue中提到的链接错误是llcppg工具在生成llgo binding时的类型名称和llgo:link中的类型名称生成不一致导致的。 这个对llgo本身编译过程的修改是为了修复何种具体链接问题需要明确。 |
0ee1e68
to
9b54b20
Compare
如会议对齐,当前PR为修复LLGO本身的链接命令解析错误导致的符号缺失问题 |
ef505fc
to
d49c4b9
Compare
c5e2731
to
e463195
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #909 +/- ##
=======================================
Coverage 97.64% 97.64%
=======================================
Files 22 22
Lines 6279 6279
=======================================
Hits 6131 6131
Misses 128 128
Partials 20 20 ☔ View full report in Codecov by Sentry. |
e463195
to
3ec58e7
Compare
_demo/cjsondemo/go.mod
Outdated
|
||
require ( | ||
github.com/goplus/llgo v0.9.9-0.20241205041715-4bec9b038b9a | ||
github.com/tsingbx/libcjson v1.0.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
llgo 增加外部库的引用会非常谨慎。这个 cjsondemo 最好迁移到 llcppg repo 中。
3457280
to
af2bcd3
Compare
No description provided.