Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssa: closure use specific struct field name #921

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

visualfc
Copy link
Member

@visualfc visualfc commented Dec 21, 2024

closure struct { f ftype, data unsafe.Pointer} => { $f ftype, $data unsafe.pointer }

abi.StructType check closure ( abi.TFlagClosure ) ignore .PkgPath_

@visualfc visualfc force-pushed the runtime.closure branch 3 times, most recently from 3388c15 to 133a05f Compare December 21, 2024 14:02
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.65%. Comparing base (070d64f) to head (a6a3c09).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #921      +/-   ##
==========================================
- Coverage   97.65%   97.65%   -0.01%     
==========================================
  Files          22       22              
  Lines        6311     6309       -2     
==========================================
- Hits         6163     6161       -2     
  Misses        128      128              
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@visualfc visualfc changed the title ssa: typeAssert check closure equal [WIP] ssa: typeAssert check closure equal Dec 21, 2024
@visualfc visualfc marked this pull request as draft December 21, 2024 14:58
@visualfc visualfc changed the title [WIP] ssa: typeAssert check closure equal [WIP] ssa: closure use specific struct field name { $f ftype, $data unsafe.pointer } Dec 22, 2024
@visualfc visualfc marked this pull request as ready for review December 22, 2024 04:35
@visualfc visualfc changed the title [WIP] ssa: closure use specific struct field name { $f ftype, $data unsafe.pointer } [WIP] ssa: closure use specific struct field name Dec 22, 2024
@visualfc visualfc changed the title [WIP] ssa: closure use specific struct field name ssa: closure use specific struct field name Dec 22, 2024
@xushiwei xushiwei merged commit 6dd4ec1 into goplus:main Dec 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants