issue314 #328
Closed
issue314 #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 175be7a.
|
[Git-flow] Hi @qlli, There are some suggestions for your information: Rebase suggestions
Which seems insignificant, recommend to use For other If you have any questions about this comment, feel free to raise an issue here: |
JiepengTan
reviewed
Sep 10, 2024
| @@ -936,7 +929,7 @@ func (p *Sprite) Step__2(step float64, animname string) { | |||
| p.goMoveForward(step) | |||
| } | |||
|
|
|||
| func (p *Sprite) playDefaultAnim() { | |||
| func (p *Sprite) playDefaultAnim(resetCostume bool) { | |||
There was a problem hiding this comment.
why need resetCostume ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify Die behavior of initial / cloned sprite #314
This fix is temporary. It's better to switch to the prefab/instance workflow like unity.