Skip to content

Commit

Permalink
Remove duplicate version call in wired gopro
Browse files Browse the repository at this point in the history
  • Loading branch information
tcamise-gpsw committed Dec 6, 2023
1 parent c1a8d23 commit 24fcb90
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Unreleased
* Add alpha support for COHN (Camera-on-the-Home-Network)
* A real implementation is going to require a major rearchitecture to dynamically add connection types.
* Remove TKinter GUI. Will be replaced with Textual TUI in the future
* Improve wifi SSID matching

0.14.1 (September-21-2022)
--------------------------
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ async def open(self, timeout: int = 10, retries: int = 1) -> None:

await self.http_command.wired_usb_control(control=Params.Toggle.ENABLE)
# Find and configure API version
version = await self.http_command.get_open_gopro_api_version()
if (version := (await self.http_command.get_open_gopro_api_version()).data) != self.version:
raise GpException.InvalidOpenGoProVersion(version)
logger.info(f"Using Open GoPro API version {version}")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@ def connect(self, ssid: str, password: str, timeout: float = 15) -> bool:
r"/System/Library/PrivateFrameworks/Apple80211.framework/Versions/Current/Resources/airport --scan"
)
lines = response.splitlines()
ssid_end_index = lines[0].index("SSID") + 4 # Find where the SSID column ends
ssid_end_index = lines[0].index("SSID") + 4 # Find where the SSID column ends

for result in lines[1:]: # Skip title row
current_ssid = result[:ssid_end_index].strip()
Expand Down

0 comments on commit 24fcb90

Please sign in to comment.