Skip to content
This repository has been archived by the owner on Feb 6, 2020. It is now read-only.

Add log compaction #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add log compaction #4

wants to merge 3 commits into from

Conversation

xiang90
Copy link
Contributor

@xiang90 xiang90 commented Jun 5, 2013

Delete the comment mark before L116 to test.
StateMachine interface is not implemented.

var aersp *raft.SnapshotResponse
var b bytes.Buffer
json.NewEncoder(&b).Encode(req)
debug("[send] POST http://%s/snapshot [%d %d]", peer.Name(), req.LastTerm, req.LastIndex)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to use a URL object here instead of sprintf'ing the URL.

@JensRantil
Copy link
Contributor

StateMachine interface is not implemented.

I've spent some time reading the source code of raft and raftd this evening. A question related to this pull request -- the StateMachine interface will need to be implemented for a snapshotting to work correctly, right?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants