chore: upgraded psr/log dependency version (added compatibility to ^v1|^v2|^v3) #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, thank you for contributing! |
|
Thank you for your feedback ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, thank you for your work, I just discovered this package.
I first used it with the cachetool.phar and saw that it can be added as a project dependency.
In a fresh SF6 app with
symfony/cache, it was not possible to runcomposer require gordalina/cachetoolas psr/log was in version 3.0 (see the above log).I could have run
composer require gordalina/cachetoo -Wto downgradepsr/logbut maybe this PR is usefull for you anyway.Please feel free to give me your feedback if it was a good idea or not.
Logs:
Problem 1
- Root composer.json requires gordalina/cachetool ^8.1 -> satisfiable by gordalina/cachetool[8.1.0].
- gordalina/cachetool 8.1.0 requires psr/log ^1.0 -> found psr/log[1.0.0, ..., 1.1.4] but the package is fixed to 3.0.0 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.