Parse --web option correctly #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`getParameterOption` returns the unparsed / unvalidated result of the option, which might result in incorrect results when reordering options: ``` php cachetool.phar opcache:status --web --web-path=/var/www ``` returns --web-path=/var/www as the value for the --web option when using `getParameterOption`, getting the parsed result is done by using `getOption` which returns the correctly parsed value, in this case `NULL`, which should result in the default being set which is FileGetContents. This avoids the warning that the webclient is unkown when passing --web without specifying the client.
|
This might be a useful change for the other options as well, and I'm happy to go through those but wanted to first fix the problem at hand, which is that I see a warning when passing |
|
This is great, thank you! Let me know if you go through the other options, I'll wait for any PRs before I issue the next release. |
|
If you are happy to take the contribution I'll go through them in the new year and get a diff ready thanks! |
Yes please! Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getParameterOptionreturns the unparsed / unvalidated result of the option, which might result in incorrect results when reordering options:returns --web-path=/var/www as the value for the --web option when using
getParameterOption, getting the parsed result is done by usinggetOptionwhich returns the correctly parsed value, in this caseNULL, which should result in the default being set which is FileGetContents.This avoids the warning that the webclient is unkown when passing --web without specifying the client.