Refactor parse configuration #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `getOption` to get the parsed value from the `--config` flag passed.
Using `getOption` on `VALUE_NONE` with either return `true` if set, or `false` if not set.
flags passed via arguments take precedence, but fallback to config file options, or defaults when not passed.
The config is either `true` or `false` which is same as `VALUE_NONE`.
if provided use the option passed otherwise use what is already set in config.
the parsed value with always be set under `tmp-dir` removing the requirement for reading the short option `-t` as well as long `--tmp-dir`. Fall back to config provided unless set.
sideshowcoder
commented
Jan 3, 2023
| if ($input->hasParameterOption('--tmp-dir') || $input->hasParameterOption('-t')) { | ||
| $this->config['temp_dir'] = $input->getParameterOption('--tmp-dir') ?: $input->getParameterOption('-t'); | ||
| } | ||
| $this->config['temp_dir'] = $input->getOption('tmp-dir') ?? $this->config['temp_dir']; |
There was a problem hiding this comment.
Using the parsed option will always yield the result under tmp-dir no need to check the short hand as well.
sideshowcoder
commented
Jan 3, 2023
| if ($input->hasParameterOption('--web-host')) { | ||
| $this->config['webHost'] = $input->getParameterOption('--web-host'); | ||
| } | ||
| $this->config['webAllowInsecure'] = $input->getOption('web-allow-insecure'); |
There was a problem hiding this comment.
I am not sure how to merge this here, I think this is a bit tricky since not providing it should set it to false, while providing it means true, no matter what the previous config value is. I don't think this is an issue so as previously this was not merged with the config from file either.
There was a problem hiding this comment.
I dont think its an issue as well.
|
Thank you! |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getOptionwhere possibleVALUE_NONEfor option--web-allow-insecurewhich does not allow for a value to be set.