Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preferred hall card #1006

Closed
wants to merge 6 commits into from
Closed

preferred hall card #1006

wants to merge 6 commits into from

Conversation

ArabellaJi
Copy link
Contributor

@ArabellaJi ArabellaJi commented Oct 5, 2023

This is for end-to-end testing. The database and backend code is rough and may need to be updated later.

Here is the front-end code:
gordon-cs/gordon-360-ui#2127

Copy link
Contributor

@andrew-wzj andrew-wzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't fully understand the change in Gordon360/Models/CCT/Context/CCTContext.cs. Otherwise, LGTM

modelBuilder.Entity<Roommate>(entity =>
{
entity.HasKey(e => new { e.ID, e.RoommateName })
.HasName("PK__Roommate__A9AF9368B01FE07C");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain the parameter in this HasName? is "PK__Roommate__A9AF9368B01FE07C" the certain primary key we need to use for addressing the roommate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a file auto-generated by EF-Core. It basically means the primary key is ID and RoommateName and its name is PK__Roommate__A9AF9368B01FE07C.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please more explicitly explain the EF-Core and why should use it to generate a series number for this Roommate?

@ArabellaJi ArabellaJi changed the title initial add roommate completed preferred hall card Nov 4, 2023
@ArabellaJi
Copy link
Contributor Author

housing-add-roommate should merge into senior-project branch first instead of housing-lottery, so I created a new pull request (#1007) and will close this one.

@ArabellaJi ArabellaJi closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants