Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to .NET 8 #1010

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Upgrade to .NET 8 #1010

merged 2 commits into from
Nov 20, 2023

Conversation

EjPlatzer
Copy link
Contributor

This Pull Request updates the API to use .NET 8 (the new Long-term Support version as of November 14, 2023). This version of .NET will be supported until 2026, and has MANY performance improvements (especially including the ones from .NET 7 as well).

While there are new features we can take advantage of by updating, they are not mandatory. After performing the upgrade with the .NET Upgrade Assistant (and testing it locally), there appear to be no breaking changes that affect our application.

@EjPlatzer EjPlatzer force-pushed the dotnet8 branch 2 times, most recently from 819e87a to 02b52b2 Compare November 17, 2023 17:04
@EjPlatzer EjPlatzer self-assigned this Nov 17, 2023
@bennettforkner
Copy link
Contributor

Have you tested this upgrade extensively? I would be surprised if nothing broke because of the version jump.

@EjPlatzer
Copy link
Contributor Author

EjPlatzer commented Nov 17, 2023

Have you tested this upgrade extensively? I would be surprised if nothing broke because of the version jump.

Yes, I tested the full application interactively and tested operations on most pages.

Also, there is no reason to suspect that anything broke. The upgrade is largely backwards compatible with only a few, extremely targeted and rare to encounter, breaking changes. The full lists are here:

I have reviewed each breaking change and none apply to our application.

Copy link
Contributor

@bennettforkner bennettforkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, good to proceed.

@EjPlatzer EjPlatzer merged commit af43295 into develop Nov 20, 2023
3 checks passed
@EjPlatzer EjPlatzer deleted the dotnet8 branch November 20, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants