Add SYB to schedules #1065
Merged
Add SYB to schedules #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EjPlatzer
requested changes
Sep 5, 2024
EjPlatzer
approved these changes
Sep 5, 2024
| @@ -188,6 +190,10 @@ private async Task<bool> CanReadOneAsync(string resource) | |||
| } | |||
| case Resource.NEWS: | |||
| return true; | |||
| case Resource.STUDENT_SCHEDULE: | |||
| if (context.ActionArguments["username"] is string viewed_username) | |||
| return user_groups.Contains(AuthGroup.Advisors) || viewed_username.EqualsIgnoreCase(user_name) || _accountService.GetAccountByUsername(viewed_username).AccountType.EqualsIgnoreCase("FACULTY"); | |||
There was a problem hiding this comment.
I am not positive that ACCOUNT.AccountType == "FACULTY" will align perfectly with the profile.PersonType.includes('fac') check that we do on the front end to decide whether to show a person's schedule to another user. That's because Profile.PersonType is calculated based on whether a row was discovered in CCT.dbo.FacultyStaff for the given user.
This is a pretty grey concern though, and won't matter once the new code is in, so it should be fine to push through in this hotfix.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.