RecIM: Include Participant's Hall in Admin view of Team's Participants #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per CTS Ticket #175058, we should display a team participant's hall to admins. This PR works in concert with gordon-cs/gordon-360-ui#2372, but neither of them depend on each other.
I added the participant's Hall to the ParticipantView in the database. I also updated the API to inlcude the Hall in the ParticipantExtendedViewModel, but only when the viewer is an admin.
This code is a little messy because we have to pass an extra parameter describing whether the view of the participant is for an Admin. However, given the spaghetti nature of the RecIM data logic, it seemed like the cleanest way to enforce that the Hall is only included in ParticipantExtendedViewModel when the viewer is an admin.