added a check for when you are asking from your profile, or your public profile #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniavonto
requested review from
russtuck,
EjPlatzer and
amos-cha
and removed request for
russtuck
|
involvements should show up grayed out because the user share those club sessions with himself and all people in the same club session can see its members. |
amos-cha
requested changes
Jul 7, 2023
| /// <param name="involvementCode">Optional involvementCode filter</param> | ||
| /// <param name="username">Optional username filter</param> | ||
| /// <param name="sessionCode">Optional session code for which session memberships should be retrieved. Defaults to current session. Use "*" for all sessions.</param> | ||
| /// <param name="participationTypes">Optional list of participation types that should be retrieved. Defaults to all participation types.</param> | ||
| /// <returns>An IEnumerable of the matching MembershipViews</returns> | ||
| [HttpGet] | ||
| [StateYourBusiness(operation = Operation.READ_PARTIAL, resource = Resource.MEMBERSHIP)] | ||
| public ActionResult<IEnumerable<MembershipView>> GetMemberships(string? involvementCode = null, string? username = null, string? sessionCode = null, [FromQuery] List<string>? participationTypes = null) | ||
| public ActionResult<IEnumerable<MembershipView>> GetMemberships(bool? myProf, string? involvementCode = null, string? username = null, string? sessionCode = null, [FromQuery] List<string>? participationTypes = null) |
There was a problem hiding this comment.
Suggested change
| public ActionResult<IEnumerable<MembershipView>> GetMemberships(bool? myProf, string? involvementCode = null, string? username = null, string? sessionCode = null, [FromQuery] List<string>? participationTypes = null) | |
| public ActionResult<IEnumerable<MembershipView>> GetMemberships(bool? myProf = false, string? involvementCode = null, string? username = null, string? sessionCode = null, [FromQuery] List<string>? participationTypes = null) |
| @@ -44,12 +45,13 @@ public ActionResult<IEnumerable<MembershipView>> GetMemberships(string? involvem | |||
| { | |||
| var authenticatedUserUsername = AuthUtils.GetUsername(User); | |||
| var viewerGroups = AuthUtils.GetGroups(User); | |||
| bool mp = myProf ?? false; | |||
There was a problem hiding this comment.
it occurred to me that we could make this variable defaulted in the parameter list
Suggested change
| bool mp = myProf ?? false; |
|
|
||
| // User can see all their own memberships. SiteAdmin and Police can see all of anyone's memberships | ||
| if (!(username == authenticatedUserUsername | ||
| || viewerGroups.Contains(AuthGroup.SiteAdmin) | ||
| || viewerGroups.Contains(AuthGroup.Police) | ||
| )) | ||
| ) || !mp) |
There was a problem hiding this comment.
Suggested change
| ) || !mp) | |
| ) || !myProf) |
I will give it a time out on this project because we found out that it might be working as intended since involvements should show up grayed out because the user share those club sections with himself. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix Issue: When you click on view my public profile your private involvements still show up for you
UI: gordon-cs/gordon-360-ui#1969