Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add efpt instructions #957

Merged
merged 3 commits into from
Jul 22, 2023
Merged

Add efpt instructions #957

merged 3 commits into from
Jul 22, 2023

Conversation

amos-cha
Copy link
Contributor

@amos-cha amos-cha commented Jul 7, 2023

No description provided.

@amos-cha amos-cha added 1 Point To measure progress s23 labels Jul 7, 2023
@amos-cha amos-cha self-assigned this Jul 7, 2023
Copy link
Contributor

@EjPlatzer EjPlatzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great first attempt at documenting how to use EF Core in our project, but it is still lacking in some ways.

docs/Database.md Outdated Show resolved Hide resolved
docs/Database.md Outdated Show resolved Hide resolved
docs/Database.md Outdated Show resolved Hide resolved
Copy link
Member

@russtuck russtuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! Students (and I) in the future will thank you (silently :-).

docs/Database.md Outdated Show resolved Hide resolved
docs/Database.md Outdated Show resolved Hide resolved
docs/Database.md Outdated Show resolved Hide resolved
Co-authored-by: Russ Tuck <russ.tuck@gordon.edu>
russtuck
russtuck previously approved these changes Jul 8, 2023
docs/Database.md Outdated Show resolved Hide resolved
@russtuck
Copy link
Member

It's really important to have these instructions for future students, and the instructions are clear an accurate. So, while the overview could indeed be improved, I think it's important to get these basic instructions merged before they are forgotten and then fail to help future students.

@russtuck russtuck merged commit 1f7c0a3 into develop Jul 22, 2023
3 checks passed
@amos-cha amos-cha deleted the s23/add-efpt-edit-instructions branch July 22, 2023 23:50
@amos-cha
Copy link
Contributor Author

It's really important to have these instructions for future students, and the instructions are clear an accurate. So, while the overview could indeed be improved, I think it's important to get these basic instructions merged before they are forgotten and then fail to help future students.

I actually went over the request change with Evan and he seems to agree with my most recent update 01f5ec9

@russtuck
Copy link
Member

russtuck commented Jul 23, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 Point To measure progress s23
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants