Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix api on saving calendar link #978

Merged
merged 9 commits into from
Jul 21, 2023
Merged

Conversation

andrew-wzj
Copy link
Contributor

Address problem on calendar links cannot be saved.

@andrew-wzj andrew-wzj requested a review from russtuck July 20, 2023 14:41
@andrew-wzj andrew-wzj self-assigned this Jul 20, 2023
@andrew-wzj andrew-wzj added 1 Point To measure progress s23 labels Jul 20, 2023
@andrew-wzj andrew-wzj linked an issue Jul 20, 2023 that may be closed by this pull request
@andrew-wzj andrew-wzj requested a review from jsenning July 20, 2023 20:35
@andrew-wzj
Copy link
Contributor Author

Address this issue :add youcanbook.me integration #1507

@andrew-wzj andrew-wzj linked an issue Jul 20, 2023 that may be closed by this pull request
Copy link
Member

@russtuck russtuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice. One very small suggestion, and a question.

Gordon360/Models/ViewModels/ProfileCustomViewModel.cs Outdated Show resolved Hide resolved
Gordon360/Documentation/Gordon360.xml Show resolved Hide resolved
Co-authored-by: Russ Tuck <russ.tuck@gordon.edu>
@russtuck russtuck dismissed their stale review July 20, 2023 21:38

Fixed the comma, investigating the unexpected change. Want someone else to be able to approve.

Gordon360/Documentation/Gordon360.xml Outdated Show resolved Hide resolved
@andrew-wzj andrew-wzj merged commit c65d5f0 into develop Jul 21, 2023
3 checks passed
@amos-cha amos-cha deleted the s23-social-links-api-fix branch July 24, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 Point To measure progress s23
Projects
None yet
3 participants