Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S23/modify term selector #981

Merged
merged 7 commits into from
Jul 22, 2023
Merged

S23/modify term selector #981

merged 7 commits into from
Jul 22, 2023

Conversation

mla04762
Copy link
Contributor

This PR is for modifying the code in the API based on the new view UserCourses that was created.

@mla04762 mla04762 added 1 Point To measure progress s23 labels Jul 21, 2023
@mla04762 mla04762 self-assigned this Jul 21, 2023
@mla04762 mla04762 marked this pull request as draft July 21, 2023 13:00
@mla04762 mla04762 requested a review from jsenning July 21, 2023 15:30
@mla04762 mla04762 marked this pull request as ready for review July 21, 2023 15:30
amos-cha
amos-cha requested changes Jul 21, 2023
View reviewed changes
Gordon360/Models/ViewModels/UserCoursesViewModel.cs Outdated Show resolved Hide resolved
Gordon360/Services/ScheduleService.cs Outdated Show resolved Hide resolved
Gordon360/Services/ScheduleService.cs Outdated Show resolved Hide resolved
@mla04762 mla04762 requested a review from amos-cha July 22, 2023 13:23
amos-cha
amos-cha requested changes Jul 22, 2023
View reviewed changes
Copy link
Contributor

@amos-cha amos-cha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last change

amos-cha
amos-cha approved these changes Jul 22, 2023
View reviewed changes
Copy link
Contributor

@amos-cha amos-cha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@mla04762 mla04762 merged commit be7f157 into develop Jul 22, 2023
3 checks passed
@mla04762 mla04762 deleted the s23/modify-term-selector branch July 22, 2023 13:38
russtuck
russtuck reviewed Jul 25, 2023
View reviewed changes
Gordon360/Services/ScheduleService.cs
.Where(s => s.UserID == account.gordon_id)
.Select(s => (UserCoursesViewModel)s)
.AsEnumerable()
.OrderByDescending(course => course.SessionCode);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mla04762 I know this is approved and merged, but it would be a great follow-on to change the order to put the latest (current or future) term first. (See issue #990). Might be as simple as ".OrderByAscending(".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be unavailable for this week, but I'll try to fix this and push it sometime hopefully before the term starts

@russtuck russtuck mentioned this pull request Jul 26, 2023
Closed
@EjPlatzer EjPlatzer mentioned this pull request Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russtuck russtuck russtuck left review comments

@amos-cha amos-cha amos-cha approved these changes

@jsenning jsenning Awaiting requested review from jsenning

Assignees

@mla04762 mla04762

Labels
1 Point To measure progress s23
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mla04762 @russtuck @amos-cha