Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rec-IM] Halls/Affiliations #987

Merged
merged 27 commits into from
Jul 24, 2023
Merged

[Rec-IM] Halls/Affiliations #987

merged 27 commits into from
Jul 24, 2023

Conversation

amos-cha
Copy link
Contributor

new Term: Affiliations.
This term pertains to all Halls/Clubs Team affiliations that can have points attributed to.

Database Changes

Team

  • (nullable) Affiliation

Series

  • WinnerID (teamID: nullable)
  • Points (points for winning this series)

new Affliation

  • Lookup Table only has name (just to retain db sanitization)

new AffiliationPoints
compound key: AffiliationName, TeamID, SeriesID

  • AffiliationName (fk Affliation)
  • TeamID (fk Team)
  • SeriesID (fk Series)
  • Points (default 0)

new view SeriesTeamView

  • SeriesTeam but with calculated SportsmanshipRating

API Changes:

  • Updating a Series to completed or back to anything from completed will cause the Series to select its own winner based on WinCount => SportsmanshipRating
  • New Routes

@amos-cha
Update ActivityVM's to include new columns
a6c2c98
@amos-cha
Update via efpt
e21cf7c
@amos-cha
Add affiliation to teamvms
9e79789
@amos-cha
Add affiliation service
6f438e5
@amos-cha
Add list of base routes for affiliations
0fa8529
@amos-cha
EFPT update affiliations
b967323
@amos-cha
EFPT update for sql models
9ec5439
@amos-cha
EFPT edit to reassign points to series instead of team
2e7c383 
Note:
EFPT has updated their schema policy and has defaulted `dbo` as nameless with `recim` as its own identifier
@amos-cha
Remove winner/points from activity
6617400
@amos-cha
Add winnerID and points to series
718f548
@amos-cha
Fix efpt merge difference
3695206
@amos-cha
Update publicalumniprofilevm
ca37c3d
@amos-cha
Update default series status
cb1aa0d
@amos-cha
Update viewmodels and controller routes
3c9000a
@amos-cha
Add prospective services
77375f4
@amos-cha
Add SeriesTeamView
b216bce 
Holds specific sportsmanship rating
@amos-cha
Apply completion logic to series (assigns winner and points)
5d0bc71
@amos-cha
Implement Get
140555e
@amos-cha
Add delete affiliations
709252d
@amos-cha
Implement put affiliations
82171f7
@amos-cha
Implement/bugfix final routes/services
5e1a04f
@amos-cha
Add stateyourbusiness
dd62e5a
@amos-cha
Forgot semicolon
df7b9f7
@amos-cha
Update affiliations => affiliation
ea9aa66
@amos-cha
Update service files to include efpt changes
cc31b3c
@amos-cha
Add FK Constraings and Compound Key to AP
1c8d06a
@amos-cha
Remove nullable points
ba427cc
@amos-cha amos-cha self-assigned this Jul 24, 2023
@amos-cha
Copy link
Contributor Author

Note: EFPT Changes their own protocol for managing filtering schemas. This has resulted in the defaulting of the dbo schema which is why we have 70 files changed.

@amos-cha amos-cha merged commit f752159 into recim Jul 24, 2023
3 checks passed
@amos-cha amos-cha deleted the recim-halls branch July 24, 2023 19:04
This was referenced Jul 24, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@amos-cha amos-cha

Labels
Rec-IM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amos-cha