-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: file paths on windows conflict with the ast escape rune #12
Conversation
f1f91b7
to
8e2d521
Compare
8e2d521
to
679b41a
Compare
Codecov Report
@@ Coverage Diff @@
## main #12 +/- ##
==========================================
+ Coverage 82.97% 83.67% +0.69%
==========================================
Files 2 2
Lines 94 98 +4
==========================================
+ Hits 78 82 +4
Misses 9 9
Partials 7 7
Continue to review full report at Codecov.
|
LGTM, @erikgeiser can you give a look as well? Thanks for the PR @djgilcrease 🙏 |
Do I understand correctly that the idea behind this is to always treat paths like Unix paths because Windows can also handle them? |
Yes, and because |
Is this a bug in https://github.com/gobwas/glob? We already pass |
kind of, because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
1e9561a
to
fda6d94
Compare
I would also say before merging this we should setup CI to test on windows as well... not sure if supported by github actions though |
Sure it is but we don't actually have that many tests that use the actual file system. |
fda6d94
to
ee26857
Compare
I would hope it is supported since MS owns github =P I added a windows style path test as I ran into issues with this when I was fixing nfpm to be able to run on windows. This project does not actually read the file system, but nfpm & goreleaser should have tests running in windows. |
…ed to keep paths in the linux style
ee26857
to
f6ee601
Compare
fix: file paths on windows conflict with the ast escape rune so we need to keep paths in the linux style
Related-To: goreleaser/goreleaser#1935