Action artifacts output is empty

[laurentsimon]

What happened?

I use the goreleaser Action. It seems like the artifacts output variable (https://github.com/goreleaser/goreleaser-action/blob/master/action.yml#L31) is empty. AFAIK, this used to work in the sense that this variable was populated (I tested over the past few weeks without encountering this problem).

See the test workflow here: https://github.com/laurentsimon/grpc-gateway/blob/master/.github/workflows/release.yml#L22-L43 and its failing run https://github.com/laurentsimon/grpc-gateway/runs/8019761254?check_suite_focus=true

artifacts:

META:

checksum_file:

Please let me know if I'm missing something. Thank you!

How can we reproduce this?

use the example workflow linked in the description.

goreleaser version

latest Action, v3

GoReleaser Check

• goreleaser check shows no errors

Search

• I did search for other open and closed issues before opening this.

Code of Conduct

• I agree to follow this project's Code of Conduct

Additional context

No response

[laurentsimon]

/cc @johanbrandhorst

[caarlos0]

weird, I'll have to investigate...

meanwhile, you should be able to replace the echo there with cat dist/artifacts.json

cc/ @crazy-max

[laurentsimon]

Thanks for the tip and quick response!

[laurentsimon]

the cat command did not work right away, but I found the culprit. The config file uses dist: _output, so we need cat _output/artifacts.json instead. It may also be why the outputs of the workflow are empty.

@johanbrandhorst I'll send a PR for this temporary fix

[crazy-max]

It seems to be populated in action ci: https://github.com/goreleaser/goreleaser-action/runs/8013357311?check_suite_focus=true#step:5:54

Code looks good too:

goreleaser-action/src/goreleaser.ts

Line 90 in ef54bd4

const artifactsFile = path.join(distpath, 'artifacts.json');

@laurentsimon Looking at logs in your workflow it doesn't seem generated: https://github.com/laurentsimon/grpc-gateway/runs/8019761254?check_suite_focus=true#step:4:50. Maybe there is an issue parsing your goreleaser yaml file in

goreleaser-action/src/goreleaser.ts

Lines 85 to 86 in ef54bd4

	const cfg = yaml.load(yamlfile);
	return cfg.dist || 'dist';

[laurentsimon]

@johanbrandhorst wrote the config file. The artifacts are successfully generated by goreleaser: does this not mean goreleaser understands the config? Or does it silently discard some fields if it does not understand them?

[laurentsimon]

Here are the generated binaries https://github.com/laurentsimon/grpc-gateway/releases/tag/v2.0.4

[caarlos0]

@johanbrandhorst wrote the config file. The artifacts are successfully generated by goreleaser: does this not mean goreleaser understands the config? Or does it silently discard some fields if it does not understand them?

judging by this, seems like the action might allow it...

the yaml is valid for goreleaser though, as it successfully executed... @crazy-max maybe the ts yaml library is failing somehow? can we add a test using @laurentsimon's config file, and maybe log the error - or exit if parse fails? wdyt?

[laurentsimon]

Fyi, this is the original config I was trying to debug https://github.com/grpc-ecosystem/grpc-gateway/blob/master/.goreleaser.yml

[crazy-max]

the yaml is valid for goreleaser though, as it successfully executed... @crazy-max maybe the ts yaml library is failing somehow? can we add a test using @laurentsimon's config file, and maybe log the error - or exit if parse fails? wdyt?

Yes this might be an issue with ts-yaml, I will take a look.

[laurentsimon]

Thanks for the quick fix!