Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dist resolution from config file #369

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Aug 26, 2022

fixes #368

YAML configuration was not correctly loaded. Also adds job in ci to check this behavior.

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #369 (0b92e1a) into master (ef54bd4) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #369   +/-   ##
=======================================
  Coverage   66.92%   66.92%           
=======================================
  Files           4        4           
  Lines         130      130           
  Branches       23       23           
=======================================
  Hits           87       87           
  Misses         25       25           
  Partials       18       18           
Impacted Files Coverage Δ
src/goreleaser.ts 56.71% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@crazy-max crazy-max force-pushed the dist branch 2 times, most recently from 49cf077 to f0b9349 Compare August 26, 2022 16:04
@crazy-max crazy-max changed the title ci: add job to check dist output from config fix: dist resolution from config file Aug 26, 2022
@crazy-max crazy-max marked this pull request as ready for review August 26, 2022 16:06
@crazy-max crazy-max requested a review from caarlos0 as a code owner August 26, 2022 16:06
Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, good one, thanks @crazy-max!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action artifacts output is empty
2 participants