Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: current tag not taken into account #329

Merged
merged 1 commit into from
Feb 28, 2022
Merged

fix: current tag not taken into account #329

merged 1 commit into from
Feb 28, 2022

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Feb 28, 2022 •
edited
Loading

@crazy-max crazy-max requested a review from caarlos0 as a code owner February 28, 2022 12:21
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #329 (d41f327) into master (c127c9b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #329   +/-   ##
=======================================
  Coverage   70.76%   70.76%           
=======================================
  Files           4        4           
  Lines         130      130           
  Branches       23       23           
=======================================
  Hits           92       92           
  Misses         25       25           
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c127c9b...d41f327. Read the comment docs.

@caarlos0
Copy link
Member

ah, good catch

@caarlos0 caarlos0 merged commit b953231 into master Feb 28, 2022
@caarlos0 caarlos0 deleted the fix-current-tag branch February 28, 2022 14:24
@crazy-max
Copy link
Member Author

@caarlos0 Yeah rookie mistake :(

@caarlos0
Copy link
Member

I reviewed and missed it too 😂

@moul-bot moul-bot mentioned this pull request Oct 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caarlos0 caarlos0 caarlos0 approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Goreleaser pulling incorrect tag information
2 participants
@crazy-max @caarlos0