Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update generated content #480

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

crazy-max
Copy link
Member

relates to https://github.com/goreleaser/goreleaser-action/actions/runs/11715158853/job/32631069786#step:3:291

  > [build-validate 1/1] RUN --mount=type=bind,target=.,rw <<EOT (set -e...):
0.214 ERROR: Build result differs. Please build first with "docker buildx bake build"
0.217  M dist/index.js
0.217  M dist/index.js.map

@caarlos0 Seems to be an oversight when #478 and other failed PRs have been merged: https://github.com/goreleaser/goreleaser-action/pulls?q=is%3Apr+is%3Aclosed

image

The build validate check is red though:

image

Before merging dependabot or when updating dependencies, you need to make sure dist is up to date otherwise the update is not used when the action is consumed. For that you need to run docker buildx bake pre-checkin and push changes similar to docker/setup-buildx-action#370: docker/setup-buildx-action@93aa1c8

image

@crazy-max crazy-max requested a review from caarlos0 as a code owner November 7, 2024 12:40
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.23%. Comparing base (14707cd) to head (39865b1).
Report is 26 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
+ Coverage   66.92%   69.23%   +2.30%     
==========================================
  Files           3        3              
  Lines         130      130              
  Branches       23       30       +7     
==========================================
+ Hits           87       90       +3     
- Misses         27       40      +13     
+ Partials       16        0      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caarlos0
Copy link
Member

caarlos0 commented Nov 7, 2024

I guess we can probably automate that?

I completely forgot I had to run that tbh

@crazy-max
Copy link
Member Author

I guess we can probably automate that?

I don't think we can as depdendabot can't trigger another worflow

@crazy-max crazy-max merged commit 9ed2f89 into goreleaser:master Nov 7, 2024
33 checks passed
@crazy-max crazy-max deleted the fix-dist branch November 7, 2024 14:40
@caarlos0
Copy link
Member

caarlos0 commented Nov 7, 2024

I guess we can probably automate that?

I don't think we can as depdendabot can't trigger another worflow

ah, right

@caarlos0
Copy link
Member

caarlos0 commented Nov 7, 2024

so maybe a daily run? so worst case its out of date for 24h 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants