Skip to content
This repository has been archived by the owner on Jan 11, 2019. It is now read-only.

timezone related error on DST on Next() #23

Open
cshiong opened this issue Dec 10, 2016 · 5 comments
Open

timezone related error on DST on Next() #23

cshiong opened this issue Dec 10, 2016 · 5 comments

Comments

@cshiong
Copy link

cshiong commented Dec 10, 2016

step to reproduce:
1.get first schedule time
schedule= 2 02 * * * *
fromTime=2016-03-12 02:03:00 -0800 PST
call Next() return: 2016-03-13T01:02:00-08:00
2. get next schedule time.
use the Next() return time as new fromTime: 2016-03-13T01:02:00-08:00
call Next() again ,and return the same value as new fromTime: 2016-03-13T01:02:00-08:00

  1. repeat step 2 and infinity loop
@abecciu
Copy link

abecciu commented Dec 10, 2016

It's fixed in PR #17

@cshiong
Copy link
Author

cshiong commented Dec 13, 2016 via email

@abecciu
Copy link

abecciu commented Dec 13, 2016

It's public, just pull the branch into your repo.

@cshiong
Copy link
Author

cshiong commented Dec 13, 2016 via email

@cshiong
Copy link
Author

cshiong commented Dec 13, 2016

on this commit, I found a new error.
seems all the job scheduled on DST start day will be scheduled at 3am (DSTFallFireLate). i assume it should be just that missing our jobs fall to early time.
e.g
schedule: 0 14 * * * * timezone: America/Los_Angeles fromTime: 2016-03-12 14:01:00 -0800 PST
reschedule to: 2016-03-13T03:00:00-07:00
in the master version, it is set correct to 2016-03-13T14:00:00-07:00

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants