refactor: extracted initial next value to constants file

gorhom · Jul 31, 2022 · 8f84968 · 8f84968
1 parent 541905f
commit 8f84968
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/components/bottomSheet/BottomSheet.tsx b/src/components/bottomSheet/BottomSheet.tsx
@@ -73,6 +73,7 @@ import {
   INITIAL_SNAP_POINT,
   DEFAULT_ENABLE_PAN_DOWN_TO_CLOSE,
   INITIAL_CONTAINER_OFFSET,
+  INITIAL_VALUE,
 } from './constants';
 import type { BottomSheetMethods, Insets } from '../../types';
 import type { BottomSheetProps, AnimateToPositionType } from './types';
@@ -210,7 +211,7 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(
       animateOnMount ? -1 : _providedIndex
     );
     const animatedPosition = useSharedValue(INITIAL_POSITION);
-    const animatedNextPosition = useSharedValue(Number.NEGATIVE_INFINITY);
+    const animatedNextPosition = useSharedValue(INITIAL_VALUE);
     const animatedNextPositionIndex = useSharedValue(0);
 
     // conditional
@@ -651,8 +652,8 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(
 
         animatedAnimationSource.value = ANIMATION_SOURCE.NONE;
         animatedAnimationState.value = ANIMATION_STATE.STOPPED;
-        animatedNextPosition.value = Number.NEGATIVE_INFINITY;
-        animatedNextPositionIndex.value = Number.NEGATIVE_INFINITY;
+        animatedNextPosition.value = INITIAL_VALUE;
+        animatedNextPositionIndex.value = INITIAL_VALUE;
       }
     );
     const animateToPosition: AnimateToPositionType = useWorkletCallback(

diff --git a/src/components/bottomSheet/constants.ts b/src/components/bottomSheet/constants.ts
@@ -20,6 +20,7 @@ const DEFAULT_KEYBOARD_BLUR_BEHAVIOR = KEYBOARD_BLUR_BEHAVIOR.none;
 const DEFAULT_KEYBOARD_INPUT_MODE = KEYBOARD_INPUT_MODE.adjustPan;
 
 // initial values
+const INITIAL_VALUE = Number.NEGATIVE_INFINITY;
 const INITIAL_SNAP_POINT = -999;
 const INITIAL_CONTAINER_HEIGHT = -999;
 const INITIAL_CONTAINER_OFFSET = {
@@ -49,4 +50,5 @@ export {
   INITIAL_CONTAINER_OFFSET,
   INITIAL_HANDLE_HEIGHT,
   INITIAL_SNAP_POINT,
+  INITIAL_VALUE,
 };