fix(#1983): updated shared values access as hook dependancies

gorhom · Oct 20, 2024 · ae41b2d · ae41b2d
1 parent 4c8ae25
commit ae41b2d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/src/components/bottomSheet/BottomSheet.tsx b/src/components/bottomSheet/BottomSheet.tsx
@@ -200,7 +200,7 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(
       return $modal
         ? _animatedContainerHeight.value - verticalInset
         : _animatedContainerHeight.value;
-    }, [topInset, bottomInset, $modal, _animatedContainerHeight.value]);
+    }, [topInset, bottomInset, $modal, _animatedContainerHeight]);
     const animatedContainerOffset = useReactiveSharedValue(
       _providedContainerOffset ?? INITIAL_CONTAINER_OFFSET
     ) as Animated.SharedValue<Insets>;
@@ -221,7 +221,7 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(
       );
     const animatedHighestSnapPoint = useDerivedValue(
       () => animatedSnapPoints.value[animatedSnapPoints.value.length - 1],
-      [animatedSnapPoints.value]
+      [animatedSnapPoints]
     );
     const animatedClosedPosition = useDerivedValue(() => {
       let closedPosition = animatedContainerHeight.value;
@@ -231,10 +231,10 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(
       }
 
       return closedPosition;
-    }, [animatedContainerHeight.value, $modal, detached, bottomInset]);
+    }, [animatedContainerHeight, $modal, detached, bottomInset]);
     const animatedSheetHeight = useDerivedValue(
       () => animatedContainerHeight.value - animatedHighestSnapPoint.value,
-      [animatedContainerHeight.value, animatedHighestSnapPoint.value]
+      [animatedContainerHeight, animatedHighestSnapPoint]
     );
     const animatedCurrentIndex = useReactiveSharedValue(
       animateOnMount ? -1 : _providedIndex
@@ -1522,7 +1522,7 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(
       return {
         paddingBottom: animatedContainerHeight.value,
       };
-    }, [animatedContainerHeight.value, detached]);
+    }, [animatedContainerHeight, detached]);
     const contentMaskContainerStyle = useMemo(
       () => [styles.contentMaskContainer, contentMaskContainerAnimatedStyle],
       [contentMaskContainerAnimatedStyle]
@@ -1581,7 +1581,7 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(
 
         evaluatePosition(ANIMATION_SOURCE.SNAP_POINT_CHANGE);
       },
-      [isLayoutCalculated.value, animatedSnapPoints.value]
+      [isLayoutCalculated, animatedSnapPoints]
     );
 
     /**

diff --git a/src/components/bottomSheetBackdrop/BottomSheetBackdrop.tsx b/src/components/bottomSheetBackdrop/BottomSheetBackdrop.tsx
@@ -106,7 +106,7 @@ const BottomSheetBackdropComponent = ({
       ),
       flex: 1,
     }),
-    [animatedIndex.value, appearsOnIndex, disappearsOnIndex, opacity]
+    [animatedIndex, appearsOnIndex, disappearsOnIndex, opacity]
   );
   const containerStyle = useMemo(
     () => [styles.container, style, containerAnimatedStyle],

diff --git a/src/components/bottomSheetScrollable/createBottomSheetScrollableComponent.tsx b/src/components/bottomSheetScrollable/createBottomSheetScrollableComponent.tsx
@@ -116,7 +116,7 @@ export function createBottomSheetScrollableComponent<T, P>(
           ? animatedFooterHeight.value
           : 0,
       }),
-      [animatedFooterHeight.value, enableFooterMarginAdjustment]
+      [animatedFooterHeight, enableFooterMarginAdjustment]
     );
     const containerStyle = useMemo(() => {
       return enableFooterMarginAdjustment