Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Error for not having flashlist even when not using the flashlist component #1968

Closed
dannyhw opened this issue Oct 14, 2024 · 5 comments
Assignees
Labels
bug Something isn't working v5

Comments

@dannyhw
Copy link

dannyhw commented Oct 14, 2024

Version

v5

Reanimated Version

v3

Gesture Handler Version

v2

Platforms

iOS, Android, Web

What happened?

When using version 5 without flashlist installed this error causes the app to crash

You need to install FlashList first,yarn install @shopify/flash-list, js engine: hermes

Since the files are all barrel files every file will run even if you don't import them so this would only be fixed by

removing the export from:
src/components/bottomSheetScrollable/index.ts and here src/index.ts

Reproduction steps

  • setup bottom sheet and don't install flashlist
  • import scrollable (not flashlist)
  • crashes

Reproduction sample

https://snack.expo.dev/@dannyhw/bottom-sheet---issue-reproduction-template

Relevant log output

You need to install FlashList first, `yarn install @shopify/flash-list`
  Evaluating @gorhom/bottom-sheet.js
  Evaluating App.js
  Loading App.js
@dannyhw dannyhw added the bug Something isn't working label Oct 14, 2024
@github-actions github-actions bot added the invalid This doesn't seem right label Oct 14, 2024
@github-actions github-actions bot locked as spam and limited conversation to collaborators Oct 14, 2024
@gorhom gorhom self-assigned this Oct 14, 2024
@gorhom gorhom removed the invalid This doesn't seem right label Oct 14, 2024
Repository owner unlocked this conversation Oct 14, 2024
Repository owner deleted a comment from github-actions bot Oct 14, 2024
@gorhom gorhom reopened this Oct 14, 2024
@gorhom gorhom added the v5 label Oct 14, 2024
@FernandoAcTr
Copy link

Same issue here

@gorhom
Copy link
Owner

gorhom commented Oct 14, 2024

this should be resolved with v5.0.2. feel free to re-open

@gorhom gorhom closed this as completed Oct 14, 2024
@sleekLancelot
Copy link

sleekLancelot commented Oct 17, 2024

this should be resolved with v5.0.2. feel free to re-open

Hi, I still face the same issue on v5.0.2, i need it for the dynamic sizing bit.
You need to install FlashList first, yarn install @shopify/flash-list, js engine: hermes

@dannyhw
Copy link
Author

dannyhw commented Oct 17, 2024

@sleekLancelot I recommend double checking you have got the right version (check lockfile) and clearing the cache because it should only throw the error now if you use the flashlist scrollable.

@sleekLancelot
Copy link

@sleekLancelot I recommend double checking you have got the right version (check lockfile) and clearing the cache because it should only throw the error now if you use the flashlist scrollable.

Had to delete it, reinstall and rebuild again. For some reason it works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v5
Projects
None yet
Development

No branches or pull requests

4 participants