feat: rewrite gesture apis with gesture handler 2 #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorhom
added a commit
that referenced
this pull request
Oct 15, 2022
* chore: updated dependencies * feat: rewrite the gesture api with gh2
gorhom
added a commit
that referenced
this pull request
Feb 19, 2023
* chore: updated dependencies * refactor: updated ReText view for web * chore: added cursor for handle container * chore: updated expo version for example project * feat: added scrollable component for web * feat: added gesture and scroll handler for web * chore: added getRefNativeTag for web * feat: rewrite gesture apis with gesture handler 2 (#1126) * chore: updated dependencies * feat: rewrite the gesture api with gh2 * fix(#1119): fixed race condition between onmount and keyboard animations * fix: update ref handler for web * chore: removed unused component * chore: updated expo * fix: detached example on web
yayvery
added a commit
to discord/react-native-bottom-sheet
that referenced
this pull request
Mar 18, 2024
* chore: updated dependencies * feat: rewrite the gesture api with gh2 gorhom@6a4d296 fix(gorhom#1119): fixed race condition between onmount and keyboard animations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #912
Motivation
This PR introduces a full re-write for gesture apis with Gesture Handler v2.
Known issues
Bottom sheet content should be only a scrollable or static content but not both, this is a regression from
v4, but it won't be addressed with this PR.Testing