Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add callback to interrupt the closing of the bottom sheet component #1359

Closed
wants to merge 3 commits into from
Closed

Add callback to interrupt the closing of the bottom sheet component #1359

wants to merge 3 commits into from

Conversation

AlexanderEggers
Copy link

Please provide enough information so that others can review your pull request:

Motivation

In certain cases we want to conditionally prevent the bottom sheet component from closing and show a warning modal to the user instead.

@AlexanderEggers AlexanderEggers changed the title feat: add callback to interrupt close Add callback to interrupt the closing of the bottom sheet component May 1, 2023
@github-actions
Copy link

github-actions bot commented Jun 3, 2023

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@AlexanderEggers
Copy link
Author

This PR is still revelant..

@AlexanderEggers
Copy link
Author

@gorhom When you have a moment, can you please review this PR?

@emmsdan
Copy link

emmsdan commented Jun 21, 2023

@gorhom
I think this PR is a relevant use case.
Found myself, having to folk and implement something similar

@gorhom gorhom self-requested a review June 21, 2023 08:40
@gorhom
Copy link
Owner

gorhom commented Jun 21, 2023

Will look into this this weekend

@karimcambridge
Copy link

karimcambridge commented Jun 25, 2023 •
edited
Loading

Related to #1320?

@AlexanderEggers
Copy link
Author

@gorhom Do you have any updates around this PR?

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@AlexanderEggers
Copy link
Author

@gorhom Any updates?

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@AlexanderEggers
Copy link
Author

This PR is still relevant

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@AlexanderEggers
Copy link
Author

@gorhom I made some minor fixes to the changes and updated the PR with the latest master. Any chance that we can get this one merged soon?

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@AlexanderEggers
Copy link
Author

@gorhom Any updates?

@henrymoulton henrymoulton mentioned this pull request Dec 4, 2023
Open
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@AlexanderEggers
Copy link
Author

This PR is still relevant.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2024

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@AlexanderEggers
Copy link
Author

@gorhom When do you think we can have this PR finally merged?

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@AlexanderEggers
Copy link
Author

This PR is still relevant.

@dima-vantage
Copy link

dima-vantage commented Apr 15, 2024 •
edited
Loading

@gorhom any updates?

@edwardanthony
Copy link

Any updates on this?

@GaeDLLD
Copy link

GaeDLLD commented May 11, 2024

Need it too !!

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot closed this Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gorhom gorhom Awaiting requested review from gorhom

Assignees
No one assigned
Labels
no-pr-activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AlexanderEggers @emmsdan @gorhom @karimcambridge @dima-vantage @edwardanthony @GaeDLLD