-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added bottom inset #237
feat: added bottom inset #237
Conversation
@DawidVanderhoven-TomTom what about for v3? Any ideas? |
thanks @DawidVanderhoven-TomTom for submitting this pr, i will review it shortly |
@gorhom I have now also provided an example and added the |
hi @DawidVanderhoven-TomTom , i have tested you pr , the example that you added works fine , but other modal examples got broken. i understand the need for this, and i would suggest to change the approach a bit, you could pass const containerStyle = useMemo(
() => [
styles.container,
{
top: topInset,
bottom: bottomInset,
overflow: 'hidden',
},
],
[bottomInset, topInset]
); and it should achieve the goal 👏 |
the solution above could be implemented easily in |
Thanks @gorhom! |
thanks @DawidVanderhoven-TomTom for submitting this pr <3 |
@gorhom plans to porting it to v3? |
@gorhom could you please suggest the way how to achieve same functionality on v3? This is critical feature, because now it's not clear how to address these issues:
I'm not sure where this should be done - on lib side or our own, but tips to this would be so much helpful. Thank you! |
I am very new to reanimated so this may be a completely incorrect way of approaching this, however this is my attempt so far. This allows you to create space below the bottom sheet in case of a situation where a footer or a bottom menu may need to be present.
This resolves #95